search

rust-ethereum / ethabi

Encode and decode smart contract invocations
Apache License 2.0
517 stars 186 forks source link

Find more maintainers for ethabi #207

Open vkgnosis opened 3 years ago

vkgnosis commented 3 years ago

The ethabi crate in particular is important to the rust ethereum ecosystem but it has many outstanding issues and PRs which has caused it to for example be forked with more patches applied like at https://github.com/gakonst/ethabi and I have personally also needed those patches for https://github.com/gnosis/ethcontract-rs and I imagine rust-web3 would benefit too.

My guess is (and please correct me if wrong) that there is currently no driving force to push bigger changes like abiv2 support. Could we find more maintainers? Who currently has write access to the repo? How should we agree on what can be merged?

Some people from Gnosis including myself probably have some capacity to review and make PRs.

vkgnosis commented 3 years ago

@gakonst tagging you because I linked your fork but that probably doesn't give you a notification. Would getting ethabi to roughly the state of your fork allow you to move back to using it?

vkgnosis commented 3 years ago

@vorot93 @kirk-baird you are the two members I see of the rust-ethereum organization so I thought I'd ping you directly.

kirk-baird commented 3 years ago

Hey, you're right seems this repo hasn't had PRs merged for a while. I'm not sure who was previously in charge of this repo.

I haven't worked on this repo before I'm in the rust-ethereum org for work on Eth2. Though I do a lot of work on solidity and Eth1 so have a solid understanding of ABI's and rust. I'm happy to do review some PRs though won't have time for active development of significant features e.g. ABIv2.

vkgnosis commented 3 years ago

Update: We've added @nlordell and myself as maintainers for this crate and we're planning on merging outstanding PRs. If other people are interested, feel free to write here.

gakonst commented 3 years ago

That's great! If all the patches from my fork were applied and you folks take over maintaining it, I'd be happy to switch to the original. I am rebased on master, so should be easy.

gakonst commented 3 years ago

@vkgnosis thanks for the work so far! Curious if you're planning on cutting a new minor release soon?

nlordell commented 3 years ago

I think we're trying to figure out Crates.io access :see_no_evil:.

gakonst commented 3 years ago

@vkgnosis @nlordell Any chance we can get a new release? I bumped on the bug which is fixed on this commit

nlordell commented 3 years ago

Should have a release https://crates.io/crates/ethabi/14.1.0