search

rust-ethereum / evm

Pure Rust implementation of Ethereum Virtual Machine
Apache License 2.0
1.16k stars 355 forks source link

Clippy pass fails #245

Closed mrLSD closed 9 months ago

mrLSD commented 9 months ago

Description

For the current master branch clippy with basic configurations fails:

cargo clippy --workspace -- -D warnings

⏩ Proposal

Fix basic clippy issues and add basic clippy rules to CI:

cargo clippy --workspace -- -D warnings
cargo clippy --workspace --no-default-features -- -D warnings
cargo clippy --workspace --features=with-codec,with-serde -- -D warnings

📓 NOTES

There are a lot of issues when enabling:

cargo clippy --workspace -- -D warnings -D clippy::pedantic -D -D clipyy::nursery

Enabling these clippy flags 🎏 is out of the current proposal.

mrLSD commented 9 months ago

Fixed in #246