search

rust-fuzz / cargo-fuzz

Command line helpers for fuzzing
https://rust-fuzz.github.io/book/cargo-fuzz.html
Apache License 2.0
1.48k stars 108 forks source link

CI tests are failing on `master` #323

Closed frewsxcv closed 1 year ago

frewsxcv commented 1 year ago

https://github.com/rust-fuzz/cargo-fuzz/actions/runs/3256280093/jobs/5346527710

fitzgen commented 1 year ago

@Shnatsel it looks like the msan tests you added in https://github.com/rust-fuzz/cargo-fuzz/pull/233 have started failing. Not sure if this is due to rustc changes or what; don't have time to investigate right now. Do you have time to take a look at this?

If not, and if no one else does either, than I think we should probably just disable the tests for now, so that other PRs can land in the mean time.

Manishearth commented 1 year ago

I agree

frewsxcv commented 1 year ago

so that other PRs can land in the mean time

yeah god forbid someone merge prs that have failing tests. who would do that??

fitzgen commented 1 year ago

heh, its mostly for new PRs that come in so we can easily differentiate between existing failing tests vs new failures easily when CI comes back failing

Shnatsel commented 1 year ago

On the latest master (commit ) the compiler straight up panicked when building with Memory Sanitizer:

Error: internal compiler error: unexpected panic note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.66.0-nightly (06f049a35 2022-10-17) running on x86_64-unknown-linux-gnu

note: compiler flags: --crate-type lib -C opt-level=3 -C embed-bitcode=no -Z force-unstable-if-unmarked -C passes=sancov-module -C llvm-args=-sanitizer-coverage-level=4 -C llvm-args=-sanitizer-coverage-inline-8bit-counters -C llvm-args=-sanitizer-coverage-pc-table -C llvm-args=-sanitizer-coverage-trace-compares -C link-dead-code -Z sanitizer=memory -Z sanitizer-memory-track-origins -C llvm-args=-sanitizer-coverage-stack-depth -C debug-assertions -C codegen-units=1

I guess we should file a bug report, as suggested?

addisoncrump commented 1 year ago

As a workaround, you can pass --strip-dead-code. See: https://github.com/rust-lang/rust/issues/101930

addisoncrump commented 1 year ago

Resolved?