search

rust-fuzz / cargo-fuzz

Command line helpers for fuzzing
https://rust-fuzz.github.io/book/cargo-fuzz.html
Apache License 2.0
1.53k stars 109 forks source link

Improve deploy actions #335

Closed Luni-4 closed 1 year ago

Luni-4 commented 1 year ago

This PR improves deploy actions simplifying some operations and removing some useless ones

Luni-4 commented 1 year ago

It seems we have to change the musl target into the gnu one due to this error: https://github.com/sifis-home/sifis-generate/actions/runs/4183591092/jobs/7248563008#step:6:86

fitzgen commented 1 year ago

It seems we have to change the musl target into the gnu one due to this error: https://github.com/sifis-home/sifis-generate/actions/runs/4183591092/jobs/7248563008#step:6:86

That is due to compiling the fuzz target with musl in that project; it shouldn't matter whether cargo fuzz itself is musl or not since the cargo fuzz binary does not include libFuzzer.

fitzgen commented 1 year ago

That is, we should not change away from musl for these deploy actions.

Luni-4 commented 1 year ago

It seems we have to change the musl target into the gnu one due to this error: https://github.com/sifis-home/sifis-generate/actions/runs/4183591092/jobs/7248563008#step:6:86

That is due to compiling the fuzz target with musl in that project; it shouldn't matter whether cargo fuzz itself is musl or not since the cargo fuzz binary does not include libFuzzer.

I haven't installed any musl library in that project, just cargo-fuzz which has been built with musl. I suppose this problem could happen to many others. Is there a workaround for that? Or can I add a gnu target to the deploy script?

I've tried to install musl libraries and launch this command cargo fuzz build --target x86_64-unknown-linux-musl but without any success

Luni-4 commented 1 year ago

@fitzgen I've decided to release a gnu binary too. What do you think?

Luni-4 commented 1 year ago

I was able to fix my problem setting up the target

cargo fuzz build --target x86_64-unknown-linux-gnu

Luni-4 commented 1 year ago

@fitzgen I rebased the PR, can we merge it now?