search

rust-fuzz / libfuzzer

Rust bindings and utilities for LLVM’s libFuzzer
Apache License 2.0
208 stars 44 forks source link

Tracking issue for 0.2.0 release #52

Closed Manishearth closed 4 years ago

Manishearth commented 4 years ago

This is being developed on the next branch Update: the next branch has been merged into `master.

We should release 0.2.0 or perhaps 1.0.0 and make cargo-fuzz start using it!

Prerequisites:

fitzgen commented 4 years ago

Perhaps name the crate libfuzzer since it's more high level than than just sys stuff?

+1 on teasing apart the bit that builds and links libfuzzer from the integration with arbitrary and the macro that users actually use and all that.

fitzgen commented 4 years ago

Perhaps name the crate libfuzzer since it's more high level than than just sys stuff?

@Manishearth since we don't want to mess with master because of all the existing git dependencies, what if we do this:

Thoughts?

Manishearth commented 4 years ago

Works for me! Perhaps we can move this repo to preserve issues and make a new one to archive?

On Sat, Jan 11, 2020, 3:02 AM Nick Fitzgerald notifications@github.com wrote:

Perhaps name the crate libfuzzer since it's more high level than than just sys stuff?

@Manishearth https://github.com/Manishearth since we don't want to mess with master because of all the existing git dependencies, what if we do this:

  • Create a new rust-fuzz/libfuzzer-rs repo that is a fork (but not in the github sense) of this repo
  • Archive this repo with a README noice to use that new repo instead
    • And now all the existing git deps will continue to work forever
  • And then we actually continue dev on the new repo:
    • transfer relevant issues over
    • split sys and highlevel utils crates (but still in same repo/workspace)
    • etc

Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rust-fuzz/libfuzzer-sys/issues/52?email_source=notifications&email_token=AAMK6SCTIVG24A3EH5Y2POTQ5DSPVA5CNFSM4KBIQB42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVIYRA#issuecomment-573213764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMK6SD7EUCMAQ4MSJW2SILQ5DSPVANCNFSM4KBIQB4Q .

Manishearth commented 4 years ago

Actually if we do this, we should name it rust-fuzz/libfuzzer probably

On Sat, Jan 11, 2020, 8:01 AM Manish Goregaokar manishsmail@gmail.com wrote:

Works for me! Perhaps we can move this repo to preserve issues and make a new one to archive?

On Sat, Jan 11, 2020, 3:02 AM Nick Fitzgerald notifications@github.com wrote:

Perhaps name the crate libfuzzer since it's more high level than than just sys stuff?

@Manishearth https://github.com/Manishearth since we don't want to mess with master because of all the existing git dependencies, what if we do this:

  • Create a new rust-fuzz/libfuzzer-rs repo that is a fork (but not in the github sense) of this repo
  • Archive this repo with a README noice to use that new repo instead
    • And now all the existing git deps will continue to work forever
  • And then we actually continue dev on the new repo:
    • transfer relevant issues over
    • split sys and highlevel utils crates (but still in same repo/workspace)
    • etc

Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rust-fuzz/libfuzzer-sys/issues/52?email_source=notifications&email_token=AAMK6SCTIVG24A3EH5Y2POTQ5DSPVA5CNFSM4KBIQB42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVIYRA#issuecomment-573213764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMK6SD7EUCMAQ4MSJW2SILQ5DSPVANCNFSM4KBIQB4Q .

fitzgen commented 4 years ago

I don't have admin access, so I can't do this shuffling. Happy to do it if you or someone else gives me that access! :)

Manishearth commented 4 years ago

Made you an org admin, go nuts!

fitzgen commented 4 years ago

Huh... I still don't have access to the admin panel or anything. Can't find an email from github that I need to accept or anything like that either...

Manishearth commented 4 years ago

I'd upgraded you to org admin, but maybe that didn't go through. Try now?

fitzgen commented 4 years ago

Ok, now I have it! Thanks!

fitzgen commented 4 years ago

Ok, this repo is now rust-fuzz/libfuzzer!

We also have an archived rust-fuzz/libfuzzer-sys repo so that the old git deps will continue to work and we don't break anyone's existing installs.

fitzgen commented 4 years ago

I also merged the next branch into master on this new repo, btw.

fitzgen commented 4 years ago

Ok I made an initial attempt at splitting this crate apart into libfuzzer and libfuzzer-sys. The libfuzzer build, and its interaction with sanitizers and code coverage, is so fragile that I immediately ran into linker errors despite only doing code motion between crates. I don't have the energy for that today.

https://github.com/fitzgen/libfuzzer/tree/split-libfuzzer-and-libfuzzer-sys if anyone else wants to take a look at it.

But I think I'm going to skip it for the 0.2.0 release of libfuzzer-sys.