search

rust-gamedev / rust-gamedev.github.io

The repository for https://gamedev.rs
https://gamedev.rs
Apache License 2.0
391 stars 345 forks source link

N50: sm64jsarchive (fixed) #1477

Closed uuphoria2 closed 2 months ago

uuphoria2 commented 2 months ago

Part of #1474

janhohenheim commented 2 months ago

Thanks for the contribution! Two points!

uuphoria2 commented 2 months ago

Thanks for the contribution! Two points!

* The style checks are failing, but it seems easy to fix:
  ![image](https://private-user-images.githubusercontent.com/9047632/321236065-03d42837-e693-4c9f-b075-80adcec79480.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI3NjUyNjgsIm5iZiI6MTcxMjc2NDk2OCwicGF0aCI6Ii85MDQ3NjMyLzMyMTIzNjA2NS0wM2Q0MjgzNy1lNjkzLTRjOWYtYjA3NS04MGFkY2VjNzk0ODAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MTBUMTYwMjQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTU3ZDNkZDczYjI0MmFhMGI1NjM2M2MzZWU4NDkyNjk5ZjQyZGFiMmIyYWFmMDAwMWFkOTQyZjQyMDNlOWM1ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Z91F9ZPnytYa8nFiFbqr2G7GUUA9YrwLdhk_FJzoY-c)

* This seems to be a JS project. Could you elaborate on what this has to do with Rust?

The backend is in rust also your check failed on the image part of it (sm64jsarchive.png) https://github.com/rust-gamedev/rust-gamedev.github.io/pull/1477/commits/9b4622637360b72d9eed9f22cf7fc7e0e190216d

uuphoria2 commented 2 months ago

@janhohenheim I tried fixing it please check again also I allowed edits by maintainers just incase.

janhohenheim commented 2 months ago

Aah I see. Cool project!

janhohenheim commented 2 months ago

@uuphoria2 I can fix the lints myself later if you are otherwise finished with the PR :)

uuphoria2 commented 2 months ago

@uuphoria2 I can fix the lints myself later if you are otherwise finished with the PR :)

Im running the rust servers for sm64jsarchive right now so note I might not be as active

uuphoria2 commented 2 months ago

@uuphoria2 I can fix the lints myself later if you are otherwise finished with the PR :)

Please do so, as I dont have much time to work on this pull request cuz im the only one maintaining the rust servers within docker for sm64jsarchive.

janhohenheim commented 2 months ago

@uuphoria2 will do, just need some time myself. The newsletter will be sent out on the the 3rd of May, so there's no rush :)

Update: will do this after #1480

uuphoria2 commented 2 months ago

Done now; thanks again for your submission!

Thank you so much.

uuphoria2 commented 2 months ago

I'll just note this to anybody viewing: The stress test already ended on april 10th tho im just here to tell how many people went on it: About 4-3 people and it was still really fun! :D

janhohenheim commented 2 months ago

Thanks for the update, I'll make sure to update the info once the editorial period starts :)