search

rust-gamedev / rust-gamedev.github.io

The repository for https://gamedev.rs
https://gamedev.rs
Apache License 2.0
391 stars 345 forks source link

Check for dead links #1486

Closed janhohenheim closed 2 months ago

janhohenheim commented 2 months ago

Fixes #189

17cupsofcoffee commented 2 months ago

FYI, Zola has a broken link checker built-in (though it's not super well-documented) - might be worth seeing how well that stacks up against this external one? That would allow it to work on local builds/without extra automation.

EDIT: In fact, it's on by default, so it might be worth trying just the broken link commit on its own to see if Zola catches it!

If that's not a good fit, this sounds like a decent alternative, though :smile:

janhohenheim commented 2 months ago

@17cupsofcoffee thanks! I intentionally am not using that because I only want to lint the files touched by the current PR, as no one should have to go over our old newsletters when links break. I don't think Zola supports that, does it?

janhohenheim commented 2 months ago

Thanks @bash for the jq code :)

janhohenheim commented 2 months ago

Done 🎉

17cupsofcoffee commented 2 months ago

@17cupsofcoffee thanks! I intentionally am not using that because I only want to lint the files touched by the current PR, as no one should have to go over our old newsletters when links break. I don't think Zola supports that, does it?

That makes sense :+1: And no, I don't think Zola supports that.

janhohenheim commented 2 months ago

@17cupsofcoffee I fixed some issues and squashed all of my changes into one clean commit. Could you approve the PR? :)