rust-italia / dgc

A parser and validator for the EU Digital Green Certificate (dgc) a.k.a. greenpass
https://github.com/rust-italia/dgc
MIT License
26 stars 11 forks source link

Triaged more tests #23

Closed lmammino closed 2 years ago

lmammino commented 2 years ago

Closes #7

We currently have 528 certificate tests passing on a total of 577 certificates (91% success rate)

The main issues identified are the following:

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4e73ec3). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage        ?   82.24%           
=======================================
  Files           ?       10           
  Lines           ?     1042           
  Branches        ?        0           
=======================================
  Hits            ?      857           
  Misses          ?      185           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e73ec3...0fa6cef. Read the comment docs.

lmammino commented 2 years ago

As mentioned offline, it's worth marking the skipped tests as #[skip] rather than commenting them out! thanks @vescoc for the suggestion!