search

rust-italia / dgc

A parser and validator for the EU Digital Green Certificate (dgc) a.k.a. greenpass
https://github.com/rust-italia/dgc
MIT License
26 stars 11 forks source link

Add support for Italian DGC settings #39

Closed dodomorandi closed 2 years ago

dodomorandi commented 2 years ago

This is a prerequisite for #38.

Support for the school parameters is still missing -- there are only end fields, start is missing. Probably these fields must be related to some other start field, probably it will be more clear once we start implementing proper validation.

I am also not sure about IncompleteSettings: should it be non_exhaustive?

codecov-commenter commented 2 years ago

Codecov Report

Merging #39 (bcefef3) into main (aee00bd) will increase coverage by 0.39%. The diff coverage is 85.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   84.73%   85.12%   +0.39%     
==========================================
  Files          11       12       +1     
  Lines         989     1862     +873     
==========================================
+ Hits          838     1585     +747     
- Misses        151      277     +126
Impacted Files Coverage Δ
dgc-italy-core/src/settings.rs 85.56% <85.56%> (ø)
dgc-italy-core/src/lib.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aee00bd...bcefef3. Read the comment docs.