rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.72k stars 309 forks source link

move the msrv configuration from 'clippy.toml' to 'Cargo.toml' #672

Closed danieleades closed 1 year ago

danieleades commented 1 year ago

what it says on the tin.

The MSRV can now be set in Cargo.toml rather than clippy.toml. Clippy parses the field from Cargo.toml.

This has the added advantage that if you try to compile this crate with a toolchain older than the MSRV you'll get a nicer error message. Or you would if the MSRV wasn't so old that it doesn't make use of the rust-version key...

still, it's the thought the counts. This change is future-proof, and is also backwards compatible, since unrecognised keys cause warnings, but not errors.

phimuemue commented 1 year ago

Hi there, thanks for this.

Prior to Rust 1.56, cargo emits a warning when encountering rust-version (see https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field), but that would be ok for me.

@jswrenn Would you be ok with that?

jswrenn commented 1 year ago

That's fine by me.

bors r+

bors[bot] commented 1 year ago

Build succeeded: