search

rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.72k stars 309 forks source link

clippy #740

Closed mightyiam closed 9 months ago

mightyiam commented 1 year ago

Co-authored-by: warren2k 846021+warren2k@users.noreply.github.com

mightyiam commented 1 year ago

This is based on top of #720 . I suggest reviewing that one, first.

mightyiam commented 1 year ago

Rebased. Please approve workflow and review. Reminder: this is based on top of #720.

mightyiam commented 1 year ago

Our last workflow run failed. Force-pushed an attempt to resolve the issue. Please approve another workflow run.

mightyiam commented 1 year ago

Could you please approve workflow? This isn't ready, though.

jswrenn commented 1 year ago

Alright, let's do clippy on stable. I don't like the idea that our CI might spontaneously break upon new Rust releases, but hopefully that's rare.

mightyiam commented 9 months ago

Looks like conflicts. I'll see what I can do.

Philippe-Cholet commented 9 months ago

I don't know if we will apply CI changes, I leave that decision to jswrenn but I sure would like to fix lints.

jswrenn commented 9 months ago

Whoops, I must have missed when this PR was marked ready for review. I'm still fine running clippy with the stable toolchain.

Philippe-Cholet commented 9 months ago

So we chose "Option B" from your https://github.com/rust-itertools/itertools/pull/740#discussion_r1335205248 in which you mention something interesting.

When bumping MSRV, go through all the allowed clippy lints in the codebase and examine which ones can now be acted upon.

I think we might easily forgot that so I think that we should have a comment on the "rust-version" line in "Cargo.toml". Once done, I'll merge this PR as jswrenn's last comment is enough confirmation to me.