search

rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.72k stars 309 forks source link

build: enforce formatting #741

Closed mightyiam closed 1 year ago

mightyiam commented 1 year ago

Could anyone please approve workflow, just for the purpose of seeing it fail?

mightyiam commented 1 year ago

Rebased. Please approve workflow and review.

mightyiam commented 1 year ago

Oh, and we did confirm enforcement works (the first commit) in this run.

mightyiam commented 1 year ago

Unsurprisingly, the checks passed. There is no good time to merge this. It may upset contributors with open pull requests. There are 40 open pull requests. Yet, that number might not decrease. Therefore, it may never be less painful than now to merge this. And it's only a click away! :shipit: :wink:

Philippe-Cholet commented 1 year ago

@mightyiam There was a recent important discussion about enforcing formatting anyway in #702 (that and more...). I guess it's currently delayed the time to try to implement some RFC.

mightyiam commented 1 year ago

Thanks. Let us know here, as soon as we can pull the trigger on this. The first commit is the enforcement part. The second is merely the result of $ cargo fmt.

Philippe-Cholet commented 1 year ago

744 bumped actions/checkout to v4, I guess you might want to do the same.

mightyiam commented 1 year ago

Thank you. Done.

jswrenn commented 1 year ago

Thank you! I'm closing this in favor of #751 (which is just a replay of the commits), for reasons explained there.