rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.72k stars 309 forks source link

use 'cargo-hack' to run MSRV check without dev dependencies #754

Closed danieleades closed 1 year ago

danieleades commented 1 year ago

decouple the MSRV check from the dev dependencies using cargo-hack

this allows dev dependencies to be updated without impacting downstream users.

note that the MSRV used in this PR was found using the following command-

cargo msrv -- cargo no-dev-deps check

(which requires installing cargo-msrv and cargo-no-dev-deps)

danieleades commented 1 year ago

latest bug looks like some kind of network error. looks superficially like https://github.com/rust-lang/cargo/issues/10303

Philippe-Cholet commented 1 year ago

I don't know much about CI configuration yet so I can only approve the documentation change about MSRV.