search

rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.72k stars 309 forks source link

Test specializations #782

Closed phimuemue closed 1 year ago

phimuemue commented 1 year ago

We have more and more specializations, but so far they are not vastly tested for iterators that have already been advanced. This PR alters test_specializations.

Philippe-Cholet commented 1 year ago

I worked some time ago on a (maybe too complex) way to test specializations (draft: https://github.com/rust-itertools/itertools/issues/756#issuecomment-1739905965) before I split focus on other things. Here, 5 as limit might be too little, at least fior some iterators, I would suggest up to 10.

phimuemue commented 1 year ago

@Philippe-Cholet Can you merge this? I‘ll raise the limit to ten when I have time.

Side note: tbh I just filed this as a PR to have the CI/Tests/Checks running, but it seems I cannot merge myself anymore (as it was the case back then with bors). Am I doing something wrong?

Philippe-Cholet commented 1 year ago

@phimuemue All the maintainer part is new to me but I guess we can not merge a PR (except jswrenn I suppose as he is an owner) especially if it has a commit we wrote without explicit approval, something like that. I think it would have work if you approved your own changes.