Closed YizhePKU closed 7 months ago
I detect a bit of impatience and I get it, I do and I'm gonna look into it.
The "check format" fails, probably just the trailing spaces. If you could remove them, and possibly squash into one commit, that would be nice.
EDIT: The old 603 is now rebased.
The "check format" fails, probably just the trailing spaces. If you could remove them, and possibly squash into one commit, that would be nice.
Done.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
33541c4
) 94.22% compared to head (7ab8480
) 94.18%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I rebased to see it work. Then I changed "self
" for "the adapted iterator" in your commit.
Thanks for this.
Document the correct behavior of nullary cartesian product.
The bug was submitted in 2019 and #603 fixes it just fine. Please just merge both this PR and PR #603 and call it a day. I understand that review time is scarce, but having automated tests pass should be good enough for this kind of change.