search

rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.69k stars 303 forks source link

Deprecate `group_by` in favor of `chunk_by` #866

Closed Philippe-Cholet closed 7 months ago

Philippe-Cholet commented 7 months ago

Finally fixes #374 (see https://github.com/rust-itertools/itertools/issues/374#issuecomment-1917543782 and above for more details).

What do you think? I'm not entirely sure of the documentation changes: when to use to term "chunk" and when to use "group".

I could additionally make "consecutive" bold.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1f69c53) 94.20% compared to head (14f5b62) 94.09%.

Files Patch % Lines
src/lib.rs 42.85% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #866 +/- ## ========================================== - Coverage 94.20% 94.09% -0.12% ========================================== Files 48 48 Lines 6676 6684 +8 ========================================== Hits 6289 6289 - Misses 387 395 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.