search

rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.64k stars 299 forks source link

Fix `deprecated_in_future` lint #877

Closed Philippe-Cholet closed 5 months ago

Philippe-Cholet commented 5 months ago

I was wondering if we should remove some deprecated parts when I encountered the lint deprecated_in_future.

usize::MAX is stable since 1.43.0. Our MSRV is 1.43.1 so this is fine and the module std::usize and usize::max_value both say "Deprecating in a future version" so I remove those.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6814180) 94.38% compared to head (c84709e) 94.30%. Report is 8 commits behind head on master.

Files Patch % Lines
src/sources.rs 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #877 +/- ## ========================================== - Coverage 94.38% 94.30% -0.09% ========================================== Files 48 48 Lines 6665 6672 +7 ========================================== + Hits 6291 6292 +1 - Misses 374 380 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.