codecov[bot]
commented
7 months ago Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
6814180) 94.38% compared to head (1dc7bce) 94.53%. Report is 10 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| src/sources.rs | 50.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #878 +/- ## ========================================== + Coverage 94.38% 94.53% +0.15% ========================================== Files 48 48 Lines 6665 6574 -91 ========================================== - Hits 6291 6215 -76 + Misses 374 359 -15 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Philippe-Cholet
At the same time as #877, I listed our deprecated parts:
Itertools::group_bysince 0.13.0
Itertools::chunk_byDo not remove!
unfoldsince 0.13.0
core::iter::from_fnMSRV ≥ 1.34.0
Do not remove!
Itertools::fold1since 0.10.2
Iterator::reduceMSRV ≥ 1.51.0
since MSRV = 1.43.1
Do not remove!
zipsince 0.10.4
core::iter::zipMSRV ≥ 1.59.0
since MSRV = 1.43.1
Do not remove!
repeat_callsince 0.8.0
core::iter::repeat_withMSRV ≥ 1.28.0
Itertools::foreachsince 0.8.0
Iterator::for_eachMSRV ≥ 1.21.0
Itertools::stepsince 0.8.0
Iterator::step_byMSRV ≥ 1.28.0
Itertools::map_resultssince 0.10.0
Itertools::map_okItertools::fold_resultssince 0.10.0
Itertools::fold_okShould we remove
repeat_call, Itertools::{foreach, step, map_results, fold_results}(which is what I did here)? Or when should we?Note: 0.8.0 and 0.10.0 are resp. 5 and 3 years old.