Closed Philippe-Cholet closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.57%. Comparing base (
6814180
) to head (3f49188
). Report is 79 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I rebased on master and added 4 commits:
Take<Skip>
over Skip<Take>
? As Skip<Take>
is simpler defined!usize::MAX
other than with panic.ExactSizeIterator
and/or DoubleEndedIterator
..get(1..=usize::MAX)
should be fine (EDIT: tested).And removed get
as a free function.
Closes #447.
So much changes happened since this work was initiated that rebase on top of master seems nothing less than a nightmare to me (I know, I tried). I therefore looked at the git differences, committed those (after formatting) and credited @wod3 and @TrolledWoods for their respective commits. Then I fixed my own review and a bit more.
I thought I would additionally implement
IteratorIndex
forEither<range, range>
(andBox<dyn range>
but I could not) but doing so would later result in a nasty breaking change if this was removed after an eventual inclusion toIterator
.Details about either
```rust impl