Closed Philippe-Cholet closed 4 months ago
Attention: Patch coverage is 50.00000%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 94.16%. Comparing base (
6814180
) to head (714ca2e
). Report is 31 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/grouping_map.rs | 50.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I just became aware of https://github.com/rust-lang/rust/issues/68125 and https://github.com/rust-lang/rust/pull/79805 and the names that were previously considered.
So we have:
Itertools::fold1
(deprecated) which basically isIterator::reduce
.Itertools::tree_fold1
deprecated/renamedtree_reduce
in #895 (not merged yet).GroupingMap::fold_first
and rename itreduce
(before I finish #901 where I might have wrote a newfold_first_in
instead ofreduce_in
).What a naming mess!
Hopefully, we might be able to remove all three deprecated methods at the same time and close this page once and for all.