rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.64k stars 299 forks source link

Deprecate `GroupingMap::fold_first` for `reduce` #902

Closed Philippe-Cholet closed 4 months ago

Philippe-Cholet commented 4 months ago

I just became aware of https://github.com/rust-lang/rust/issues/68125 and https://github.com/rust-lang/rust/pull/79805 and the names that were previously considered.

So we have:

What a naming mess!

Hopefully, we might be able to remove all three deprecated methods at the same time and close this page once and for all.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.16%. Comparing base (6814180) to head (714ca2e). Report is 31 commits behind head on master.

Files Patch % Lines
src/grouping_map.rs 50.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #902 +/- ## ========================================== - Coverage 94.38% 94.16% -0.23% ========================================== Files 48 48 Lines 6665 6755 +90 ========================================== + Hits 6291 6361 +70 - Misses 374 394 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.