Closed Philippe-Cholet closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.38%. Comparing base (
6814180
) to head (81bac92
). Report is 45 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't know about you but I think it's hard to know what is accessible outside the crate (except manually reading docs.rs entirely).
pub
without documentation is private thanks to#![warn(missing_docs)]
(denied in CI) butpub
with a small documentation might be public without us knowing.I therefore considered adding
#![deny(unreachable_pub)]
(description there). After doing so and (easily) fixing 60+ errors andripgrep "pub "
, I found out thatTakeWhileInclusive
has a public methodnew
while we usually do not publish such method.I'm actually not fully satisfied with
unreachable_pub
because somepub
remain without being accessible outside the crate. (Maybe public-api is better suited for this).Anyway, I here made
TakeWhileInclusive::new
private.