rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.76k stars 309 forks source link

Fix/ignore warnings within doctests #964

Closed Philippe-Cholet closed 4 months ago

Philippe-Cholet commented 4 months ago

963 lead me to know about #![doc(test(attr(...)))].

Our doctests have some warnings that are ignored by default. Here, I fix some, sometimes silently (comment out), and globally ignore deprecated and unstable_name_collisions. Maybe I should allow(unused_variables) instead of many # let _ = ...;?

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.51%. Comparing base (6814180) to head (9238e2a). Report is 108 commits behind head on master.

Files Patch % Lines
src/lib.rs 87.50% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #964 +/- ## ========================================== + Coverage 94.38% 94.51% +0.12% ========================================== Files 48 49 +1 Lines 6665 7072 +407 ========================================== + Hits 6291 6684 +393 - Misses 374 388 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.