Closed Ciel-MC closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.24%. Comparing base (
6814180
) to head (65e49a1
). Report is 112 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Ciel-MC Maybe #[doc(alias = "TakeUntil")]
on TakeWhileInclusive
?
Seems reasonable to me!
However, there is
Iterator::take_while
so it does not come from nowhere. 😀
I do understand that it didn't come from nowhere, but it is a bit like calling 2 "1+1", like yes it came from adding 1 to 1, but it has a pretty common name already.
@Ciel-MC Maybe
#[doc(alias = "TakeUntil")]
onTakeWhileInclusive
?
I mean, I guess that is just as searchable? Though I'm not sure why you'd want it on the struct instead of the method(excuse my inexperience with api design)
It was a question. After searching doc aliases on rust-lang/rust, it sure does not alias structs much if at all, my bad.
Thanks
I could not for the life of me find this function lmao, it's called take until most places so I think an alias for searchability would be nice