search

rust-itertools / itertools

Extra iterator adaptors, iterator methods, free functions, and macros.
https://docs.rs/itertools/
Apache License 2.0
2.76k stars 309 forks source link

Update some of itertools' dev-dependencies to their latest versions #986

Open LikeLakers2 opened 3 months ago

LikeLakers2 commented 3 months ago

It seems itertools has a few outdated development dependencies. I recommend updating them to their latest version, if for no other reason than you'll be running with the latest code.

PS Github:\rust-itertools\itertools> cargo outdated --root-deps-only --workspace

itertools
================
Name        Project  Compat  Latest  Kind         Platform
----        -------  ------  ------  ----         --------
criterion   0.4.0    ---     0.5.1   Development  ---
quickcheck  0.9.2    ---     1.0.3   Development  ---
rand        0.7.3    ---     0.8.5   Development  ---

From some quick testing, it appears updating criterion is as simple as changing the version in Cargo.toml. If updating it is wanted, I am willing to put out a quick PR with the change.

As for quickcheck and rand, the changes needed to support the latest version appear to be far more extensive, so I will leave updating those to contributors who are more familiar with the itertools codebase.

jswrenn commented 3 months ago

So long as updating a dev dependency doesn't cause issues with testing/benchmarking on our MSRV, I'm happy to accept PRs that do so!

LikeLakers2 commented 3 months ago

@jswrenn Then I will see about putting out a PR later today for updating criterion. :)