search

rust-lang-ar / rust-lang-ar.github.io

Argentina's Rust Community Site
https://rust-lang-ar.github.io/
Apache License 2.0
8 stars 3 forks source link

Initial layout #13

Closed Phosphorus-M closed 2 years ago

Phosphorus-M commented 3 years ago

Agregado en la landing page:

En teoría todo es responsive de momento, faltan varias cosas pero bueno, es un comienzo.

El diseño que se viene usando es este desde luego esta abierto a cambios y sugerencias.

EstebanBorai commented 3 years ago

@Phosphorus-M I think it would be nice to have screenshots here, so we can see what's being merged

EstebanBorai commented 3 years ago

@Phosphorus-M please fix GitHub actions clippy and fmt issues, its important to keep our codebase as clean as possible, remember to run both commands before pushing to GitHub.

cargo fmt && cargo clippy
EstebanBorai commented 2 years ago

@Phosphorus-M please make sure you rebase! It makes easier PR reviewing.

EstebanBorai commented 2 years ago

The router looks good so far, but I believe we will encounter issues with client side routing given that we are using GitHub Pages which (AFAIK) it doesn't support client-side routing.

We would have to either use a hash router for this or change our hosting provider to make it work as expected.