rust-lang-ar / rust-lang-ar.github.io

Argentina's Rust Community Site
https://rust-lang-ar.github.io/
Apache License 2.0
8 stars 3 forks source link

Design | Hero dimensions are not accurate to the design #16

Closed EstebanBorai closed 1 year ago

EstebanBorai commented 3 years ago

Current

image

Notes

Expected

image

https://xd.adobe.com/view/a6e8590a-79fc-48f7-b07d-03411c8df981-f3bb/screen/4ca7f176-c725-49c1-ac81-93e99adaea90

Phosphorus-M commented 3 years ago

In point 2, Hero's main text is not semi-bold in the mock it's in bold. And besides, the scale is in 1920px like in the mockup if you want see how the page look changes the resolution.

The font size in the mock is not responsive, is important to understand that the design is not prepared for mobile. If I use the exact font size in the mock it's possible that I break the design but even so I did a changes