error-chain currently produces `unknown lint` warning on stable

BenjaminGill-Metaswitch commented 7 years ago

e.g. (from https://travis-ci.org/rust-lang-nursery/error-chain/jobs/259646671):

warning: unknown lint: `unused_doc_comment`
   --> tests/tests.rs:621:5
    |
621 | /     error_chain! {
622 | |         links { }
623 | |
624 | |         foreign_links { }
...   |
631 | |         }
632 | |     };
    | |______^
    |
    = note: #[warn(unknown_lints)] on by default
    = note: this error originates in a macro outside of the current crate

This seems to be due to unused_doc_comment being a new warning that's present in nightly only.

Would it be worth adding #[allow(unknown_lints)] to some of the macros?

BenjaminGill-Metaswitch commented 7 years ago

Also, would it be sensible to start denying warnings in CI to catch this sort of thing in future?

BenjaminGill-Metaswitch commented 7 years ago

I've just written #209, which should fix this.

rust-lang-deprecated / error-chain

error-chain currently produces `unknown lint` warning on stable #208