search

rust-lang-deprecated / error-chain

Error boilerplate for Rust
Apache License 2.0
729 stars 111 forks source link

Fix new renamed_and_removed_lints warning #247

Closed bjgill closed 6 years ago

bjgill commented 6 years ago

Builds on @hoodie's work in #246 to allow both unused_doc_comment and unused_doc_comments in a fully back-compatible fashion.

Fixes #245

faern commented 6 years ago

Getting rid of these warnings would be very much appreciated.

lucab commented 6 years ago

Ping @Yamakaky and @brson to get this reviewed, merged and released.

brson commented 6 years ago

Thanks @Yamakaky

On Jun 16, 2018 4:59 AM, "Yamakaky" notifications@github.com wrote:

Merged #247 https://github.com/rust-lang-nursery/error-chain/pull/247.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rust-lang-nursery/error-chain/pull/247#event-1684630301, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI_DjlFWXv1ig-qlQHl6eTMvdm90iFCks5t9PMygaJpZM4UWxT4 .

dvdplm commented 6 years ago

Would be amazing to get a release out with this, perhaps a backport and a tiny release on 0.11 too? :)

lucab commented 6 years ago

0.12.0 is on crates.io. Thanks @Yamakaky!

fogti commented 6 years ago

251