search

rust-lang-deprecated / error-chain

Error boilerplate for Rust
Apache License 2.0
728 stars 111 forks source link

try to fix issue #251 #252

Closed fogti closed 5 years ago

fogti commented 6 years ago

I think that the following modification (seen in quick-error) could work here, to fix issue #251. I splitted the problematic part in two parts:

  1. ignore unknown/renamed/removed lints
  2. disable warnings about unused doc comments
fogti commented 6 years ago

https://github.com/tailhook/quick-error/commit/34a67cc98592f90f25ba01277d172196ed855dc6

AndyGauge commented 5 years ago

I'm trying to push for a release for some minor changes that have serious impact on users. If you don't mind, I would like to hold off on this one.

fogti commented 5 years ago

This fixes an issue with rustc 1.27.0 (and probably 1.28.0, too), which doesn't apply the (#allow) unknown_lints, renamed_and_removed_lints to unused_doc_comment, unused_doc_comments, when these lints-to-ignore are in the same line

AndyGauge commented 5 years ago

Thanks, that was news to me!