Remove deprecated Error::description

rust-lang-deprecated / error-chain

Error boilerplate for Rust

Apache License 2.0

728 stars 111 forks source link

Remove deprecated Error::description #283

Closed AnderEnder closed 4 years ago

AnderEnder commented 4 years ago

Error::description has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.

This PR:

Removes an implementation of description in impl ::std::error::Error
Cleanups description from foreign_link_variant
Increases minimal version to 1.27.0 in travis

AndyGauge commented 4 years ago

That's quite the leap in minimum supported rust. Do the tests fail on 1.13?

AndyGauge commented 4 years ago

I dug into this and sure enough, with 1.41 release, our next breaking version would need to support 1.27 at minimum or error in compilation. An alternative option would be to https://crates.io/crates/rustversion conditionally compile the trait.

AnderEnder commented 4 years ago

@AndyGauge, there is another option: to allow deprecated methods.

AnderEnder commented 4 years ago

Closing in favour of https://github.com/rust-lang-nursery/error-chain/pull/285