search

rust-lang-deprecated / error-chain

Error boilerplate for Rust
Apache License 2.0
728 stars 111 forks source link

Use Error::description only for rust below 1.42 #285

Closed AnderEnder closed 4 years ago

AnderEnder commented 4 years ago

Error::description has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon (1.42)

This PR:

Related PR: https://github.com/rust-lang/rust/pull/66919 Alternative PR(with removed description): https://github.com/rust-lang-nursery/error-chain/pull/283

AndyGauge commented 4 years ago

I'm a fan of this approach.

ndmitchell commented 4 years ago

Any chance of a release containing this fix? Thanks

AndyGauge commented 4 years ago

Yeah, give me a week or two, but I will release it.

LukasKalbertodt commented 4 years ago

@AndyGauge Ping regarding release. People start noticing this on stable (#286). Thanks! :) (I think I don't have the rights to release this...)

AndyGauge commented 4 years ago

shoot you are right, I'm behind on this. Tomorrow.

AndyGauge commented 4 years ago

🎉 0.12.2 is on crates.io Let me know if it breaks production 😉