search

rust-lang-deprecated / error-chain

Error boilerplate for Rust
Apache License 2.0
728 stars 111 forks source link

src: Remove executable bit from source files #289

Closed cgwalters closed 4 years ago

cgwalters commented 4 years ago

I know this seems silly, but RPM builds of https://github.com/coreos/coreos-installer/ are failing for me because RPM sticks these source files in "debugsource" directories, and then a "linter" check notices they appear to be executable but lack a shebang #! line.

There's no reason for source to be directly executable, so remove that bit.

bgilbert commented 4 years ago

Commit 542c12c8a1683df6898f73ce64e6534c96c8a9c9 reinstated the execute bit on lib.rs (and, indeed, every other file it touched).

AndyGauge commented 4 years ago

Perfect! glad to hear we’ve regressed.

On Jul 31, 2020, at 9:39 PM, Benjamin Gilbert notifications@github.com wrote:

Commit 542c12c https://github.com/rust-lang-nursery/error-chain/commit/542c12c8a1683df6898f73ce64e6534c96c8a9c9 reinstated the execute bit on lib.rs (and, indeed, every other file it touched).

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/rust-lang-nursery/error-chain/pull/289#issuecomment-667468153, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRZBXTCPE7XOIUNR4LR7HDR6OL7FANCNFSM4LSJFNBA.

cgwalters commented 4 years ago

Andy, what's the umask value on your system? Is your editor creating files with the executable bit by default for some reason?

AndyGauge commented 4 years ago

I'm using windows subsystem for linux on the machine I just released from. The file system that holds the files is NTFS and the file system adapter ends up causing these problems.
I'll be releasing 0.12.4 with a mac to avoid the problem.

AndyGauge commented 4 years ago

OK, I've published 0.12.4 to address this problem. I'll try to be more cognizant of the file permissions on all of the codebases I touch because of this, but I do apologize for this learning experience impacting other's workflow.