search

rust-lang-deprecated / rust-packaging

Packaging for Rust + Cargo in multiple formats
Apache License 2.0
16 stars 11 forks source link

MSI: Prevent overlapping of GNU and MSVC installers #46

Closed gentoo90 closed 8 years ago

gentoo90 commented 8 years ago

Currently installing one ABI will uninstall the other ABI of the same channel.

Change UpgradeCode for MSVC installer. Add ABI name to ProductName and INSTALLDIR for both ABIs. Breaking change: MSVC won't be able to upgrade the old installers.

rust-highfive commented 8 years ago

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

brson commented 8 years ago

cc @vadimcn @retep998 what do you think of this?

retep998 commented 8 years ago

There's already separate installations for each version of Rust, so the installers already can't upgrade over old versions, the old version always has to be uninstalled manually. Having separate installations for different ABIs would be following that precedent, for better or for worse. Although in my opinion if you want multiple installations of Rust you should just use multirust.

vadimcn commented 8 years ago

This change looks good to me.

Yah, for multiple installations multirust would probably be better, but does that mean we should limit "unirust" installations to one-at-a-time?

brson commented 8 years ago

Thanks for the reviews.