search

rust-lang-deprecated / rust-packaging

Packaging for Rust + Cargo in multiple formats
Apache License 2.0
16 stars 11 forks source link

Fix default install directory for MSI per-user installs #47

Closed ollie27 closed 8 years ago

ollie27 commented 8 years ago

The correct directory is %LocalAppData%\Programs from: https://msdn.microsoft.com/en-us/library/windows/desktop/dd408068.aspx

There is probably a more correct way of doing this because the installer is supposed to automatically redirect from ProgramFilesFolder for per-user installs.

rust-highfive commented 8 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

brson commented 8 years ago

@vadimcn Does this look ok to you?

vadimcn commented 8 years ago

Yes, I think this is fine.