search

rust-lang-deprecated / rust-packaging

Packaging for Rust + Cargo in multiple formats
Apache License 2.0
16 stars 11 forks source link

New MSI artwork #54

Closed Boddlnagg closed 8 years ago

Boddlnagg commented 8 years ago

During my work for an MSI installer for rustup I looked at the existing artwork for the Rust MSI installer and tried to improve it a little bit. Feel free to reject this PR if you don't like these changes, or tell me if I should adjust something. I also added the GIMP files (with layers).

One could then also use this artwork (maybe with a little upwards arrow added to the logo) for the rustup MSI installer.

rust-highfive commented 8 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

retep998 commented 8 years ago

Does the artwork have to be .bmp?

Boddlnagg commented 8 years ago

At least when support for Windows 7 or earlier is required, only BMP and JPEG are supported (https://msdn.microsoft.com/en-us/library/aa367830.aspx). Since it has been a BMP before, I used BMP again.

brson commented 8 years ago

Looks like an improvement to me. Though I don't like using brown for Rust artwork (too obvious, too ugly). Still, we can revisit later, maybe when we have some unifying art style for Rust.