rust-lang-ja / ac-library-rs

ac-library-rs is a rust port of AtCoder Library (ACL).
Creative Commons Zero v1.0 Universal
224 stars 26 forks source link

Make the names of graph structs consistent #93

Open universato opened 3 years ago

universato commented 3 years ago

main

Now: SccGraph, MfGraph, MinCostFlowGraph

Expected1: Scc(or SCC), MaxFlow, MinCostFlow

Expected2: SccGraph, MaxFlowGraph, MinCostFlowGraph

Expected3: SccGraph, MfGraph, McfGraph

All graph names need to be changed, but I prefer expected1.

Other data structures

In reference,

lang struct, impl file
Rust Dsu dsu URL
Rust SccGraph scc URL
Rust MfGraph maxflow URL
Rust MinCostFlowGraph mincostflow URL
Rust Segtree segtree URL
Rust LazySegtree lazysegtree URL
Rust TwoSat twosat URL
Rust ModInt modint URL

Other language libraries

In reference,

Lang SCC MaxFlow MinCostFlow
C++ scc_graph mf_graph mcf_graph
C# SccGraph MFGraph/MaxFlow.cs McfGraph/MinCostFlow.cs
Python SCCGprah MFGraph MCFGraph
Rust SccGraph MfGraph MinCostFlowGraph
Go SccGraph --- ---
D SccGraph MfGraph McfGraph
Java SCC MaxFlow MinCostFlow
Kotolin SCC MaxFlow MinCostFlow
Ruby SCC MaxFlow MinCostFlow
Crystal SCC MaxFlow MinCostFlow
TonalidadeHidrica commented 1 year ago

This is just renaming the names, so it may be worth considering before the language update.

qryxip commented 1 year ago

@TonalidadeHidrica @mizar I prefer "Expected2". What do you think?