search

rust-lang-nursery / lazy-static.rs

A small macro for defining lazy evaluated static variables in Rust.
Apache License 2.0
1.91k stars 111 forks source link

Version 1.1.0 bumps minimum compiler version #114

Closed jethrogb closed 5 years ago

jethrogb commented 6 years ago

Version 1.1.0 bumps the minimum compiler version because of the use of associated constants. This is not a semver-compatible change and should be reverted.

BurntSushi commented 6 years ago

There is no consensus on whether bumping the MSRV is a semver incompatible change or not.

jethrogb commented 6 years ago

My CI started failing overnight because of this release even though I employ lockfiles everywhere.

sfackler commented 6 years ago

What does "employing lockfiles everywhere" mean? If your versions are locked, then you wouldn't pick up a new version with a higher compiler version requirement.

jethrogb commented 6 years ago

Yeah, I suppose that's quite puzzling. I've narrowed it down to an optional dependency that only gets activated through a particular feature. This dependency is not in the lockfile.

jethrogb commented 6 years ago

Caused by https://github.com/rust-lang/cargo/issues/3629

KodrAus commented 6 years ago

Yeh the 1.1.0 release didn't bump the minimum compiler version. The additional build.rs specifically exists to avoid bumping the minimum compiler version.

jethrogb commented 6 years ago

That might not be working correctly then:

02:00:25   --> /home/jenkins/.cargo/registry/src/github.com-1ecc6299db9ec823/lazy_static-1.1.0/src/heap_lazy.rs:17:5
02:00:25    |
02:00:25 17 |     pub const INIT: Self = Lazy(0 as *const T, ONCE_INIT);
02:00:25    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
02:00:25    |
02:00:25    = help: add #![feature(associated_consts)] to the crate attributes to enable
02:00:25 
02:00:25 error: aborting due to previous error(s)
02:00:25 
02:00:25 error: Could not compile `lazy_static`.

I don't get this error on 1.0.2

KodrAus commented 6 years ago

@jethrogb Oh are you compiling lazy_static on a compiler before 1.21.0? While we didn't bump our documented minimum supported version from 1.21.0 we might've bumped our technically supported minimum version by actually using a feature that stabilized close to 1.21.0?

jethrogb commented 6 years ago

I'm on 1.18

we didn't bump our documented minimum supported version from 1.21.0

Documented where exactly?

KodrAus commented 6 years ago

Documented where exactly?

It's documented as the explicit version we test in Travis through our .travis.yml, but you could reasonably argue that totally doesn't count as documentation. It's clearly not discoverable...

Maybe we should adopt the approach some other crates take and stick a badge in the readme with our minimum version?

BurntSushi commented 6 years ago

Digging a little deeper here...

There are no rigid policies on how to handle all of this, but it is a bit of a mess. This also means regex's documented minimum version is technically wrong because it is less than lazy_static's documented minimum version (a dependency of regex). I don't really know what to do about it. I'm not sure it's worth this amount of fuss at this point, at least until we get some sort of LTS release that core crates can rally around.

KodrAus commented 6 years ago

Hm it is a bit of a mess... I think we've made a few assumptions that lead to this specific case:

Some sort of LTS release would nicely cut through those assumptions in the future. It seems like our efforts right now across the ecosystem to manage minimum versions are a bit too ad-hoc to scale.

BurntSushi commented 6 years ago

It seems like our efforts right now across the ecosystem to manage minimum versions are a bit too ad-hoc to scale.

I agree. I watch the repos of (almost?) every dependency I use, including this one, and specifically look out for this and I still missed it. :-(