search

rust-lang-nursery / lazy-static.rs

A small macro for defining lazy evaluated static variables in Rust.
Apache License 2.0
1.9k stars 111 forks source link

Prepare for 1.2.0 release #131

Closed KodrAus closed 5 years ago

KodrAus commented 5 years ago

Current changeset

This release includes a change that bumps our minimum supported rustc version from 1.21.0 to 1.24.1 in order to solve a soundness issue (see #117 for details). This compiler version does seem to be readily available in package managers.

cc @Kimundi @eddyb @RalfJung

also cc @BurntSushi @jethrogb (who might be interested in the minimum version bump)

KodrAus commented 5 years ago

It looks like we could roll #130 in too.

jethrogb commented 5 years ago

I appreciate the notification but I don't see what use it is, unless you're prepared to have this discussion about minimum Rust version all over again.

KodrAus commented 5 years ago

Yeh the ping was mostly out of courtesy. We wouldn't have bumped the minimum version if there was a sound way to fix #117 without it.

Oh since we've bumped past 1.22 we should be able to simplify/remove the build script now too.

BurntSushi commented 5 years ago

Thanks for the ping!

On Wed, Oct 31, 2018, 21:20 Ashley Mannix <notifications@github.com wrote:

Yeh the ping was mostly out of courtesy. We wouldn't have bumped the minimum version if there was a sound way to fix #117 https://github.com/rust-lang-nursery/lazy-static.rs/issues/117 without it.

Oh since we've bumped past 1.22 we should be able to simplify/remove the build script now too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rust-lang-nursery/lazy-static.rs/pull/131#issuecomment-434899564, or mute the thread https://github.com/notifications/unsubscribe-auth/AAb34iaSJuarEhSv6e579gMANi-mxGmHks5uqkxKgaJpZM4YFmOI .