rust-lang-nursery / lazy-static.rs

A small macro for defining lazy evaluated static variables in Rust.
Apache License 2.0
1.9k stars 111 forks source link

Remove "nightly" feature #136

Closed Ericson2314 closed 5 years ago

Ericson2314 commented 5 years ago

I believe it is dead code now? Somewhere in the switching from heap to inline-only it became redundant, it looks like.

KodrAus commented 5 years ago

Thanks for the suggestion @Ericson2314! This seems reasonable to me, since the nightly feature isn't considered stable.

Would you like to submit a PR?

Ericson2314 commented 5 years ago

I'm a bit swamped with other things (and don't use travis much myself). Just was reading this again and noticed.

KodrAus commented 5 years ago

Ah no worries :+1: If anybody would like to contribute this it'd be much appreciated!

Ericson2314 commented 5 years ago

If there was just that one line, I would have done it myself :). I think what's left is:

KodrAus commented 5 years ago

Ah thanks! I thought we'd already removed the nightly feature from CI but didn't actually check.

I'll chase up these extra bits.