Update to spin 0.7 for a more performant spinlock

rust-lang-nursery / lazy-static.rs

A small macro for defining lazy evaluated static variables in Rust.

Apache License 2.0

1.9k stars 108 forks source link

Update to spin 0.7 for a more performant spinlock #181

Closed zesterer closed 2 years ago

zesterer commented 3 years ago

A lot of improvements were made for spin 0.7, one of which was the relaxing of unnecessarily strict ordering guarantees. The changes should improve performance of the no-std version of this crate considerably.

KodrAus commented 3 years ago

We'd welcome a PR updating spin to the latest version!

zesterer commented 3 years ago

I'll do so if I find some time over the next few days.

ColinFinck commented 2 years ago

Looks like #182 has been merged and this issue can be closed? (sorry, I have no permissions to do that myself)

zesterer commented 2 years ago

It might be worth upgrading to 0.9. For the purpose of this crate, an advantage is that it places the crates (many) features behind feature flags (although you'll need to disable the default ones), reducing unnecessary compilation work.

KodrAus commented 2 years ago

We've merged #193 that bumps the spin crate to 0.9. I'll need to get permissions sorted before we can publish a release but will try get on top of that.