rust-lang-nursery / lazy-static.rs

A small macro for defining lazy evaluated static variables in Rust.
Apache License 2.0
1.92k stars 111 forks source link

Migrate to GitHub Actions #203

Closed KodrAus closed 3 months ago

KodrAus commented 2 years ago

While I'm here we should migrate those compile tests to trybuild :eyes:

smoelius commented 2 years ago

While I'm here we should migrate those compile tests to trybuild eyes

May I ask, what benefit would this provide? (This is a serious question, BTW.)

KodrAus commented 2 years ago

@smoelius There are two main ones I'm interested in:

  1. Not needing to set up a separate project to run compile tests, since they're what exercises most of the library. trybuild has a simpler API to work with.
  2. We might be able to get rid of some hacks we've accumulated to work around complexities in invoking Cargo the way these libraries do. We've had to shim lazy-static to make the old tests work because it's been a dependency of the compiler.
smoelius commented 2 years ago

Thanks, @KodrAus. I would be curious to see what those changes would look like.