search

rust-lang-nursery / lazy-static.rs

A small macro for defining lazy evaluated static variables in Rust.
Apache License 2.0
1.91k stars 111 forks source link

Enable the const_unsafe_cell_new feature flag for nightly #84

Closed jedisct1 closed 6 years ago

KodrAus commented 6 years ago

Thanks @jedisct1!

This depends on https://github.com/mvdnes/spin-rs/pull/42

KodrAus commented 6 years ago

This looks good to me. @Kimundi are we ok to merge this and push out a point release?

KodrAus commented 6 years ago

Another fix for this I think would be https://github.com/rust-lang-nursery/lazy-static.rs/pull/55 which removes the need for this feature flag.

Kimundi commented 6 years ago

Looks good, thanks!

joshlf commented 6 years ago

Looks like this might not be sufficient - since the version of spin that's required is just 0.4, existing Cargo.lock files with 0.4.5 or below will still cause breakage because spin only fixed this issue in 0.4.6.

sfackler commented 6 years ago

It seems pretty expected that people may have to update dependencies to fix bugs?

joshlf commented 6 years ago

Well right now, this will just show itself as a compilation failure - it wouldn't be obvious that updating to a newer version would fix things. If we changed the dependency to spin = 0.4.6, then it would show itself as a failure to resolve dependencies, which would make it very obvious what needed to be done.