search

rust-lang-nursery / rust-cookbook

https://rust-lang-nursery.github.io/rust-cookbook
Creative Commons Zero v1.0 Universal
2.26k stars 284 forks source link

Use mdbook-linkcheck #572

Open pickfire opened 4 years ago

pickfire commented 4 years ago

https://lib.rs/crates/mdbook-linkcheck

It seemed better integrated with mdbook and uses the existing flow, mdbook build.

KappaDistributive commented 4 years ago

Note that this will also require updating mdbook to at least version 0.3.0.

pickfire commented 4 years ago

I wonder if there is still a maintainer for rust cookbook.

KappaDistributive commented 4 years ago

@AndyGauge is still around -- don't worry.

As it is the nature with these side projects, attention/activity will fluctuate.

AndyGauge commented 4 years ago

I won't rewrite the build scripts to use a different link checker, but will accept a PR that correctly moves to a rust solution.

pickfire commented 4 years ago

I tried doing this but looks like the link checker implementation is quite different and there are some stuff that is not valid (I also found broken links at https://rust-lang-nursery.github.io/rust-cookbook/web/clients.html). I got confused on what how the link works, the error is pointing to some random place.