Use mmap64 on Linux. - Githubissues

rust-lang / backtrace-rs

Backtraces in Rust

https://docs.rs/backtrace

Other

537 stars 246 forks source link

Closed mikebenfield closed 1 year ago

mikebenfield commented 1 year ago

mmap is a non-LFS function and due to its usage here will appear in binaries produced by rustc.

This is relevant to rust-lang/rust#94173.

mikebenfield commented 1 year ago

cargo test --features gimli-symbolize --manifest-path crates/without_debuginfo/Cargo.toml

fails in CI on Ubuntu but passes on my machine. It's not clear to me how my change could cause this.

mikebenfield commented 1 year ago

Alright, this test fails on someone else's commit too, so I guess my PR is not responsible.

workingjubilee commented 1 year ago

See also:

inglorion commented 1 year ago

I would like to get this merged. mikebenfield told me I'm free to take over the work. Can we continue on this PR or should I create a new one?

workingjubilee commented 1 year ago

Okay. Most of the CI checks pass now, and the remainder don't because of... missing the nightly toolchain? Whatever. This looks good, merging.