search

rust-lang / backtrace-rs

Backtraces in Rust
https://docs.rs/backtrace
Other
526 stars 245 forks source link

Adapt to new Fuchsia target name #509

Closed flba-eb closed 1 year ago

flba-eb commented 1 year ago

CI fails because there is no std lib available:

error: toolchain 'nightly-x86_64-unknown-linux-gnu' does not contain component 'rust-std' for target 'x86_64-fuchsia'

Availability monitor: https://rust-lang.github.io/rustup-components-history/

flba-eb commented 1 year ago

The failing test is not related to this change, see issue #511.

JohnTitor commented 1 year ago

Could we pin the nightly version for that target or use build-std instead?

workingjubilee commented 1 year ago

I agree: using cargo {command} -Zbuild-std is much more robust as a solution. It should still be removed eventually since we should be shipping a tier 2 target??? I don't know what's happening there.

Also this should be rebased on master just to make sure the CI run accurately reflects the current CI.

workingjubilee commented 1 year ago

Though also, hmmm.

I wonder, is rustbot functional on this repo? Because this should really be

@rustbot ping fuchsia

rustbot commented 1 year ago

Error: This repository is not enabled to use triagebot. Add a triagebot.toml in the root of the default branch to enable it.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

workingjubilee commented 1 year ago

RIP.

JohnTitor commented 1 year ago

Ah, I see! https://github.com/rust-lang/rust/pull/106429 renamed the target and the components are no longer shipped via that name. Using x86_64-unknown-fuchsia should resolve the problem here. (More info: https://github.com/rust-lang/rust/pull/106636 re-added them to the supported targets, but it doesn't mean we can do rustup target add x86_64-fuchsia, it seems.)

flba-eb commented 1 year ago

CI for Fuchsia seems to work now 😃 , but not all tests have been run (because of https://github.com/rust-lang/backtrace-rs/issues/511).