search

rust-lang / backtrace-rs

Backtraces in Rust
https://docs.rs/backtrace
Other
526 stars 245 forks source link

deps: update miniz_oxide to 0.7 #521

Closed poliorcetics closed 1 year ago

poliorcetics commented 1 year ago

I don't think this change the MSRV but I haven't really checked.

Could a new release be done with this too ?

JohnTitor commented 1 year ago

Unfortunately it breaks MSRV (it'd become 1.46) but I think it's old enough to do so: https://github.com/rust-lang/rust/pull/72437

poliorcetics commented 1 year ago

Sorry for the delay on this, hopefully I didn't miss anything when updating MSRV

poliorcetics commented 1 year ago

= note: ld: error: unable to find library -lunwind

I don't know what's needed for this to work for android

MarijnS95 commented 1 year ago

= note: ld: error: unable to find library -lunwind

I don't know what's needed for this to work for android

That also happens on master, fwiw :)

poliorcetics commented 1 year ago

I’ll remove my test commits for android tomorrow, I was trying to fix the compilation issue but it didn’t work, no need to keep them

poliorcetics commented 1 year ago

MSRV was updated to 1.55 on master so I don't need to upgrade it in this MR anymore :)