search

rust-lang / backtrace-rs

Backtraces in Rust
https://docs.rs/backtrace
Other
524 stars 240 forks source link

Enable calling build.rs directly from std/build.rs #556

Closed pitaj closed 1 year ago

pitaj commented 1 year ago

This, I feel, is a slightly better way of achieving https://github.com/rust-lang/rust/pull/99883

Once this is merged, and backtrace is synced to rust-lang/rust, this patch (based on that PR) can be applied to rust-lang/rust.

bjorn3 commented 1 year ago

Maybe do the same as you want to do in libstd's build script for the as-if-std crate? That acts as a test for using it in libstd.

github-actions[bot] commented 1 year ago

Below is the size of a hello-world Rust program linked with libstd with backtrace.

Original binary size: 533976B Updated binary size: 530480B Difference: -3496B (-0.65%)

workingjubilee commented 1 year ago

Can you look into the 32-bit Windows issue?

pitaj commented 1 year ago

@workingjubilee

As far as I can tell, all of the CI failures are due to spurious network failures from crates.io

If you can restart some of those jobs, I imagine they would pass on the second go.

workingjubilee commented 1 year ago

32-bit Windows seemed to have another issue but now it's passing? Weird.

pitaj commented 1 year ago

All I saw was the spurious network error stuff. What did you see?

workingjubilee commented 1 year ago

I thought it had broken on the concurrent panics test.

pitaj commented 1 year ago

Hmm. Well if you can find the log, I can look into it, otherwise I think you might have it confused with something else.

workingjubilee commented 1 year ago

I'm going to blame this one on "eventual consistency".