search

rust-lang / backtrace-rs

Backtraces in Rust
https://docs.rs/backtrace
Other
516 stars 237 forks source link

Make sgx functions exist with cfg(miri) #591

Closed saethlin closed 4 months ago

saethlin commented 4 months ago

https://github.com/rust-lang/backtrace-rs/pull/581 actually broke builds of the sgx target with Miri worse :upside_down_face:

This time I tested this patch by applying this patch to the Rust tree and doing

MIRI_LIB_SRC=/home/ben/rust/library/ cargo +nightly miri setup --target=x86_64-fortanix-unknown-sgx
workingjubilee commented 4 months ago

Oops?

workingjubilee commented 4 months ago

@RalfJung Can you doublecheck here

saethlin commented 4 months ago

Oops indeed.

saethlin commented 4 months ago

Well, Ralf did kind of already suggest this: https://github.com/rust-lang/backtrace-rs/pull/581#discussion_r1523301774

RalfJung commented 4 months ago

The only way to check this is to actually do the build, me staring at the code won't help.

workingjubilee commented 4 months ago

Fair enough!