search

rust-lang / backtrace-rs

Backtraces in Rust
https://docs.rs/backtrace
Other
516 stars 237 forks source link

Fix CI and remove rustc-serialize #596

Closed ChrisDenton closed 3 months ago

ChrisDenton commented 3 months ago

@workingjubilee I'm not clear why we weren't doing this already. It would have caught the stripping issue earlier. There's a very old comment about only testing on nightly but that's the opposite of what we were doing.

Obviously this will still currently fail CI until rustc or cargo is patched.

workingjubilee commented 3 months ago

no idea.

blocked on https://github.com/rust-lang/rust/issues/122857

workingjubilee commented 3 months ago

after 1.77.1 gets out the door tomorrowish this can become fixing up our CI in general and removing the hack.

ChrisDenton commented 3 months ago

1.77.1 is released but now something else is broken in nightly.

ChrisDenton commented 3 months ago

Oh rustc-serialize, gah. Why do we still have that, lol.

ChrisDenton commented 3 months ago

https://github.com/rust-lang/rust/issues/123156

ChrisDenton commented 3 months ago

Ok, everything is working again except for the binary size check problem.

ChrisDenton commented 3 months ago

now that deriving RustcDecodable and RustcEncodable is officially officially unstable, how would you feel about removing it? I feel like maybe we should bite that bullet before being forced to?

workingjubilee commented 3 months ago

Hell yeah let's fucking kill that shit off.

workingjubilee commented 3 months ago

backtrace 0.4 here we come.

ChrisDenton commented 3 months ago

Yay! 🥳 Should that be a separate PR?

workingjubilee commented 3 months ago

I honestly do not care.

ChrisDenton commented 3 months ago

Your enthusiasm is infectious so I've just done it right here right now.

workingjubilee commented 3 months ago

Nice.

bjorn3 commented 3 months ago

backtrace 0.4 here we come.

Technically you don't even need to. If cargo fails to find a feature in one crate version it will look for other crate versions for one which does have the feature. So if anyone depends on the rustc-serialize feature, cargo will simply force usage of an older backtrace version which still supports rustc-serialize.

workingjubilee commented 3 months ago

Oh cool.

workingjubilee commented 3 months ago

If it was a feature I expected people to realistically depend on I'd worry about this but nah.