search

rust-lang / backtrace-rs

Backtraces in Rust
https://docs.rs/backtrace
Other
516 stars 237 forks source link

Use correct base address and update comment #604

Closed ChrisDenton closed 3 months ago

ChrisDenton commented 3 months ago

I've been staring at the code a lot lately but somehow missed that we're returning the wrong thing for the module base. It probably works out ok because a) most things only care that the pointer points to something within the right module and b) backtrace doesn't use it.

I added a comment because apparently I need the obvious pointed out to me.

Also while I'm at it I updated a 64-bit comment to remove the stuff commenting on 32-bit code (which is now in another file).

workingjubilee commented 3 months ago

@ChrisDenton This appears to break the dead code warnings for some platforms?

ChrisDenton commented 3 months ago

Wait... what?! Hmm...

ChrisDenton commented 3 months ago

Oh, nightly lints changing again. Gah.